dongjoon-hyun closed pull request #46346: [SPARK-48098][INFRA] Enable
`NOLINT_ON_COMPILE` for all except `lint` job
URL: https://github.com/apache/spark/pull/46346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dongjoon-hyun commented on code in PR #46346:
URL: https://github.com/apache/spark/pull/46346#discussion_r1588493621
##
project/SparkBuild.scala:
##
@@ -257,7 +257,7 @@ object SparkBuild extends PomBuild {
lazy val sharedSettings = sparkGenjavadocSettings ++
dongjoon-hyun commented on code in PR #46346:
URL: https://github.com/apache/spark/pull/46346#discussion_r1588493621
##
project/SparkBuild.scala:
##
@@ -257,7 +257,7 @@ object SparkBuild extends PomBuild {
lazy val sharedSettings = sparkGenjavadocSettings ++
dongjoon-hyun commented on PR #46346:
URL: https://github.com/apache/spark/pull/46346#issuecomment-2091864830
Thank you for review and approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gengliangwang commented on code in PR #46346:
URL: https://github.com/apache/spark/pull/46346#discussion_r1588500715
##
project/SparkBuild.scala:
##
@@ -257,7 +257,7 @@ object SparkBuild extends PomBuild {
lazy val sharedSettings = sparkGenjavadocSettings ++
dongjoon-hyun commented on code in PR #46346:
URL: https://github.com/apache/spark/pull/46346#discussion_r1588500029
##
project/SparkBuild.scala:
##
@@ -257,7 +257,7 @@ object SparkBuild extends PomBuild {
lazy val sharedSettings = sparkGenjavadocSettings ++
dongjoon-hyun commented on code in PR #46346:
URL: https://github.com/apache/spark/pull/46346#discussion_r1588499484
##
project/SparkBuild.scala:
##
@@ -257,7 +257,7 @@ object SparkBuild extends PomBuild {
lazy val sharedSettings = sparkGenjavadocSettings ++
gengliangwang commented on code in PR #46346:
URL: https://github.com/apache/spark/pull/46346#discussion_r1588499107
##
project/SparkBuild.scala:
##
@@ -257,7 +257,7 @@ object SparkBuild extends PomBuild {
lazy val sharedSettings = sparkGenjavadocSettings ++
dongjoon-hyun commented on PR #46346:
URL: https://github.com/apache/spark/pull/46346#issuecomment-2091853883
Could you review this PR once more, @gengliangwang ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dongjoon-hyun commented on code in PR #46346:
URL: https://github.com/apache/spark/pull/46346#discussion_r1588493621
##
project/SparkBuild.scala:
##
@@ -257,7 +257,7 @@ object SparkBuild extends PomBuild {
lazy val sharedSettings = sparkGenjavadocSettings ++
dongjoon-hyun commented on PR #46346:
URL: https://github.com/apache/spark/pull/46346#issuecomment-2091830231
Oh, sorry. I need to revise this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dongjoon-hyun commented on PR #46346:
URL: https://github.com/apache/spark/pull/46346#issuecomment-2091823433
Thank you so much, @gengliangwang .
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dongjoon-hyun commented on PR #46346:
URL: https://github.com/apache/spark/pull/46346#issuecomment-2091765767
Hi, @gengliangwang . Could you review this PR when you have some time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
13 matches
Mail list logo
