dongjoon-hyun commented on code in PR #46346: URL: https://github.com/apache/spark/pull/46346#discussion_r1588493621
########## project/SparkBuild.scala: ########## @@ -257,7 +257,7 @@ object SparkBuild extends PomBuild { lazy val sharedSettings = sparkGenjavadocSettings ++ compilerWarningSettings ++ - (if (sys.env.contains("NOLINT_ON_COMPILE")) Nil else enableScalaStyle) ++ Seq( + (if (!sys.env.get("NOLINT_ON_COMPILE").contains("false")) enableScalaStyle else Nil) ++ Seq( Review Comment: 1. no env variable => `enableScalaStyle` 2. `NOLINT_ON_COMPILE=false` => Nil 3. `NOLINT_ON_COMPILE` has other values => `enableScalaStyle` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org