Re: [PR] [SPARK-43046][FOLLOWUP][SS][CONNECT] Remove not used line in deduplicateWithinWatermark [spark]

2024-05-03 Thread via GitHub
HyukjinKwon closed pull request #46345: [SPARK-43046][FOLLOWUP][SS][CONNECT] Remove not used line in deduplicateWithinWatermark URL: https://github.com/apache/spark/pull/46345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-43046][FOLLOWUP][SS][CONNECT] Remove not used line in deduplicateWithinWatermark [spark]

2024-05-03 Thread via GitHub
HyukjinKwon commented on PR #46345: URL: https://github.com/apache/spark/pull/46345#issuecomment-2092723762 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-43046][FOLLOWUP][SS][CONNECT] Remove not used line in deduplicateWithinWatermark [spark]

2024-05-02 Thread via GitHub
WweiL commented on PR #46345: URL: https://github.com/apache/spark/pull/46345#issuecomment-2091752280 cc @zhengruifeng Hi Ruifeng, I believe this line was added just to align with the behavior of this commit, https://github.com/apache/spark/commit/92847d98810280c9ddebea2e12a5e4945601f809.

[PR] [SPARK-43046][FOLLOWUP][SS][CONNECT] Remove not used line in deduplicateWithinWatermark [spark]

2024-05-02 Thread via GitHub
WweiL opened a new pull request, #46345: URL: https://github.com/apache/spark/pull/46345 ### What changes were proposed in this pull request? An extra assignment was added when we first introduce `dropDuplicatesWithinWatermark` in