WweiL commented on PR #46345: URL: https://github.com/apache/spark/pull/46345#issuecomment-2091752280
cc @zhengruifeng Hi Ruifeng, I believe this line was added just to align with the behavior of this commit, https://github.com/apache/spark/commit/92847d98810280c9ddebea2e12a5e4945601f809. But I think we don't have a `drop_duplicates_within_watermark` API. We could either add one, or remove that assignment. May I get your inputs as the original author of that PR? Thank you in advance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org