gene-db commented on PR #46372: URL: https://github.com/apache/spark/pull/46372#issuecomment-2093845240
@dongjoon-hyun > * Could you provide a test case to validate your contribution and to prevent any future regression at this area? Yes, the previous PR added many [tests](https://github.com/apache/spark/blob/b42d235c29302b9faa4254d07db1282207345f69/sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnVectorSuite.scala#L503) in this area, to make sure it is correct. The reason I am updating in this PR is to go back to using primitive arrays (and still produce correct results with the tests), which are faster than the object ones. > * I'd like to recommend to use `[SQL]` in SQL module PR title next time. Ok, I will add the appropriate module name next time. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
