anishshri-db commented on code in PR #46351: URL: https://github.com/apache/spark/pull/46351#discussion_r1589732558
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala: ########## @@ -351,7 +351,7 @@ private[sql] class HDFSBackedStateStoreProvider extends StateStoreProvider with } override def close(): Unit = { - synchronized { loadedMaps.values.asScala.foreach(_.clear()) } + synchronized { loadedMaps.keySet().asScala.toSeq.foreach(loadedMaps.remove) } Review Comment: Yea for large state - our memory usage would increase too. So thought that this way might be better - to continue working with the shallow references ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org