anishshri-db commented on code in PR #46351:
URL: https://github.com/apache/spark/pull/46351#discussion_r1588758558
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -584,7 +584,21 @@ object StateStore extends Logging {
}
def stop(): Unit = {
- threadPool.shutdown()
+ logInfo("Shutting down MaintenanceThreadPool")
+ threadPool.shutdown() // Disable new tasks from being submitted
+
+ // Wait a while for existing tasks to terminate
+ if (!threadPool.awaitTermination(60, TimeUnit.SECONDS)) {
Review Comment:
Why not just do `awaitTermination` once with a large timeout value - 5m
maybe ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
