nchammas commented on code in PR #46354: URL: https://github.com/apache/spark/pull/46354#discussion_r1588642424
########## python/MANIFEST.in: ########## @@ -16,7 +16,7 @@ # Reference: https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html -graft pyspark +recursive-include pyspark *.pyi py.typed *.json Review Comment: @HyukjinKwon - Instead of this, I prefer to exclude tests as follows: ```diff $ diff python/MANIFEST-json.in python/MANIFEST-notests.in 19c19 < recursive-include pyspark *.pyi py.typed *.json --- > graft pyspark 31a32 > global-exclude **/tests/** ``` That way, if we add new files in the future that don't happen to match the glob expressions on this line they will still be picked up. But I believe you prefer the approach taken here, so I've started with that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
