#35404: Admin fieldset multiple flexbox regressions
------------------------------------+------------------------------------
     Reporter:  minusf              |                    Owner:  nobody
         Type:  Bug                 |                   Status:  new
    Component:  contrib.admin       |                  Version:  4.2
     Severity:  Normal              |               Resolution:
     Keywords:  css admin fieldset  |             Triage Stage:  Accepted
    Has patch:  0                   |      Needs documentation:  0
  Needs tests:  0                   |  Patch needs improvement:  0
Easy pickings:  0                   |                    UI/UX:  1
------------------------------------+------------------------------------
Comment (by Sarah Boyce):

 > If you are happy with the patch for the height issue (no 2.), ...

 I think you can also remove the line-height

 {{{#!diff
 M django/contrib/admin/static/admin/css/forms.css
 @@ -84,14 +84,13 @@ form ul.inline li {
      min-width: 160px;
      width: 160px;
      word-wrap: break-word;
 -    line-height: 1;
  }

  .aligned label:not(.vCheckboxLabel):after {
      content: '';
      display: inline-block;
      vertical-align: middle;
 -    height: 1.625rem;
  }

 }}}
 Looks ok to me
 [[Image(image-20240429-085114.png)]]

 > ...,  I can start a pull request and work from there.

 Please do! I also think (2) should be a separate commit to (1) and (3)
 (maybe a commit message something like... Refs #35404 -- Fixed line height
 of admin fieldset labels.)
-- 
Ticket URL: <https://code.djangoproject.com/ticket/35404#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f28a57141-fb511c93-bada-4ea1-a8b4-32becb60abba-000000%40eu-central-1.amazonses.com.

Reply via email to