Control: tag -1 patch
Hi!
On Wed, 2024-03-13 at 12:56:21 +0100, Lucas Nussbaum wrote:
> Source: rlinetd
> Version: 0.9.3-2
> Severity: serious
> Justification: FTBFS
> Tags: trixie sid ftbfs
> User: lu...@debian.org
> Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef
> This is most likely caused by a change in dpkg 1.22.6, that enabled
> -Werror=implicit-function-declaration. For more information, see
> https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
>
> Relevant part (hopefully):
> > /bin/bash ../libtool --tag=CC --mode=link
> > /<<PKGBUILDDIR>>/debian/gcc-wrapper gcc -I../.. -g -O2
> > -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> > -fstack-protector-strong -fstack-clash-protection -Wformat
> > -Werror=format-security -fcf-protection -Wall -Wextra -Wwrite-strings
> > -Wcast-qual -Wbad-function-cast -Wpointer-arith -Wmissing-prototypes
> > -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -Wcast-align
> > -Winline -Wshadow -Wredundant-decls -export-dynamic -Wl,-z,relro -Wl,-z,now
> > -o rlinetd buffer.o bytecode.o connect.o db.o error.o engine.o main.o
> > stack.o strings.o signals.o -ldl ../port/libport.a -lcap
> > ../../src/cleanups.c: In function ‘rlp_cleanup’:
> > ../../src/cleanups.c:27:49: error: implicit declaration of function
> > ‘pmap_unset’ [-Werror=implicit-function-declaration]
> > 27 |
> > pmap_unset(rlcu->prog, nl->num);
> > | ^~~~~~~~~~
> > ../../src/cleanups.c:27:49: warning: nested extern declaration of
> > ‘pmap_unset’ [-Wnested-externs]
> > cc1: some warnings being treated as errors
> > make[4]: *** [Makefile:603: cleanups.lo] Error 1
This is the symptom, but the actual problem is from the rpc code
having been removed from glibc, and packages now needing to link
against libtirpc instead. The attached patch solves this. Although for
upstream submission this should be done in configure.ac instead.
Thanks,
Guillem
diff -Nru rlinetd-0.9.3/debian/control rlinetd-0.9.3/debian/control
--- rlinetd-0.9.3/debian/control 2024-01-26 00:37:24.000000000 +0100
+++ rlinetd-0.9.3/debian/control 2024-05-03 20:30:29.000000000 +0200
@@ -7,6 +7,7 @@
debhelper-compat (= 13),
flex,
libcap2-dev [linux-any],
+ libtirpc-dev,
libwrap0-dev
Rules-Requires-Root: no
Homepage: https://salsa.debian.org/debian/rlinetd
diff -Nru rlinetd-0.9.3/debian/rules rlinetd-0.9.3/debian/rules
--- rlinetd-0.9.3/debian/rules 2024-01-26 00:37:24.000000000 +0100
+++ rlinetd-0.9.3/debian/rules 2024-05-03 20:34:21.000000000 +0200
@@ -7,7 +7,9 @@
DESTDIR := $(CURDIR)/debian/$(shell dh_listpackages)
DEB_BUILD_MAINT_OPTIONS := hardening=+all
+DEB_CPPFLAGS_MAINT_APPEND := $(shell pkgconf --cflags libtirpc)
DEB_CFLAGS_MAINT_APPEND := $(shell getconf LFS_CFLAGS)
+DEB_LDFLAGS_MAINT_APPEND := $(shell pkgconf --libs libtirpc)
DPKG_EXPORT_BUILDFLAGS := 1
include /usr/share/dpkg/buildflags.mk
