Source: servefile
Version: 0.5.4-3
Severity: normal
Tags: patch
X-Debbugs-Cc: d...@debian.org, wb-t...@buildd.debian.org
Control: affects -1 buildd.debian.org
Hi,
servefile fails to build when self.getIPs() does not return an IP:
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File
"/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_servefile/build/servefile/__main__.py",
line 3, in <module>
servefile.main()
File
"/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_servefile/build/servefile/servefile.py",
line 1289, in main
server.serve()
File
"/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_servefile/build/servefile/servefile.py",
line 1008, in serve
self.server.append(self._createServer(self.handler))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File
"/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_servefile/build/servefile/servefile.py",
line 982, in _createServer
self.genKeyPair()
File
"/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_servefile/build/servefile/servefile.py",
line 927, in genKeyPair
for ip in self.getIPs() + ["127.0.0.1", "::1"]:
~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
TypeError: unsupported operand type(s) for +: 'NoneType' and 'list'
This fails in sbuild with the unshare backend. A simple fix would be:
--- servefile-0.5.4.orig/servefile/servefile.py
+++ servefile-0.5.4/servefile/servefile.py
@@ -890,7 +890,7 @@ class ServeFile():
ips = [ip for ip in ips if ':' in ip]
return ips
- return None
+ return []
def setSSLKeys(self, cert, key):
""" Set SSL cert/key. Can be either path to file or pyopenssl
X509/PKey object. """
Cheers Jochen
